Re: [whatwg/storage] Add a storage key comparison algorithm (PR #134)

@annevk commented on this pull request.

Thanks, looks good modulo nits.

> @@ -229,6 +229,17 @@ settings object</a> <var>environment</var>, run these steps:
  <li><p>Return <var>key</var>.
 </ol>
 
+<p>To determine whether a <a>storage key</a> <var>A</var>
+<dfn export for="storage key" id=concept-storage-key-equals lt=equal>equals</dfn> <var>B</var>, run

Let's repeat "a storage key" in front of _B_ for maximum clarity.

> @@ -229,6 +229,17 @@ settings object</a> <var>environment</var>, run these steps:
  <li><p>Return <var>key</var>.
 </ol>
 
+<p>To determine whether a <a>storage key</a> <var>A</var>
+<dfn export for="storage key" id=concept-storage-key-equals lt=equal>equals</dfn> <var>B</var>, run
+these steps:
+
+<ol>
+ <li><p>If <var>A</var>'s <a for="storage key">origin</a> is not <a lt="same origin">same-origin</a>

"same origin" sans hyphen is what we typically use.

> @@ -229,6 +229,17 @@ settings object</a> <var>environment</var>, run these steps:
  <li><p>Return <var>key</var>.
 </ol>
 
+<p>To determine whether a <a>storage key</a> <var>A</var>
+<dfn export for="storage key" id=concept-storage-key-equals lt=equal>equals</dfn> <var>B</var>, run

Also no need to include an ID here. For new things we let Bikeshed generate one.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/134#pullrequestreview-880377236
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/storage/pull/134/review/880377236@github.com>