- From: Mike West <notifications@github.com>
- Date: Tue, 05 Apr 2022 09:16:05 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 5 April 2022 16:16:17 UTC
@mikewest approved this pull request. Apologies for the delay. I've read through the diff, and I'm happy with where this ended up. I have only one dumb nit. Otherwise LGTM. > + <p>The order of the <a for=/>IP addresses</a> <a>resolve an origin</a> can return return can differ between invocations. Nit: I stumbled over this while reading. Since you're here, would you mind making a small change along the lines of the following? (The double "return" should be fixed regardless.) ```suggestion <p>The order of the <a for=/>IP addresses</a> that the <a>resolve an origin</a> algorithm can return can differ between invocations. ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1325#pullrequestreview-932156264 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1325/review/932156264@github.com>
Received on Tuesday, 5 April 2022 16:16:17 UTC