Re: [w3c/manifest] Add id member to manifest (#988)

@philloooo commented on this pull request.



> +        </ol>
+        <aside class="example">
+          <p>Below table shows some example cases of the |identity| processing algorithm.</p>
+          <table class="data">
+            <tr>
+              <th>|json|["id"]</th>
+              <th>|manifest|["start_url"]</th>
+              <th>|manifest|["id"]</th>
+            </tr>
+            <tr>
+              <td><i>undefined</i></td>
+              <td>"https://example.com/my-app/start"</td>
+              <td>"https://example.com/my-app/start"</td>
+            </tr>
+            <tr>
+              <td>""</td>

thanks Matt! Yeah my main concern is with the con you already said. If we make start_url as the base_url, then I think the leading slash has to be required, which then basically mean the base_url is the root. Otherwise using start_url as base_url + not requiring to have leading slash make it very error-prone to devs.

I will make the update for the empty string!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/988#discussion_r714403481