- From: Matt Giuca <notifications@github.com>
- Date: Wed, 22 Sep 2021 17:37:32 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/988/review/761515163@github.com>
@mgiuca commented on this pull request. > + </ol> + <aside class="example"> + <p>Below table shows some example cases of the |identity| processing algorithm.</p> + <table class="data"> + <tr> + <th>|json|["id"]</th> + <th>|manifest|["start_url"]</th> + <th>|manifest|["id"]</th> + </tr> + <tr> + <td><i>undefined</i></td> + <td>"https://example.com/my-app/start"</td> + <td>"https://example.com/my-app/start"</td> + </tr> + <tr> + <td>""</td> If we aren't keen on my above suggestion (a quick chat with Phillis offline suggests not), then I think going with Marcos' suggestion is good. It's actually consistent with how [scope is parsed](https://www.w3.org/TR/appmanifest/#dfn-process-the-scope-member): - If it's missing, invalid, **or empty**, it defaults to `start_url`. - If not, it's parsed against manifest URL. So we've already got that weird condition "if empty default to something other than the base URL it's being parsed against" in the `scope` processor. We would be doing the same thing here. Ultimately, if we recommend that users always start `id` with '/', then none of this matters, so let's make sure we always recommend that and do this small change and move on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/988#discussion_r714401653
Received on Thursday, 23 September 2021 00:37:44 UTC