- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 20 Sep 2021 22:39:46 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 21 September 2021 05:39:59 UTC
@marcoscaceres commented on this pull request. > + <aside class="example"> + <p>Below table shows some example cases of the |identity| processing algorithm.</p> + <table class="data"> + <tr> + <th>|json|["id"]</th> + <th>|manifest|["start_url"]</th> + <th>|manifest|["id"]</th> + </tr> + <tr> + <td><i>undefined</i></td> + <td>"https://example.com/resources/start"</td> + <td>"https://example.com/resources/start"</td> + </tr> + <tr> + <td>""</td> + <td>"https://example.com/resources/start"</td> Nit: let's drop the "resources"... and instead of "foo", let's call it "my-app", just so it's a bit more concrete. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/988#pullrequestreview-759318789
Received on Tuesday, 21 September 2021 05:39:59 UTC