- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 20 Sep 2021 22:38:28 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 21 September 2021 05:38:40 UTC
@marcoscaceres commented on this pull request. > + <li>Let |id:URL| be the result of [=URL Parser|parsing=] |json|["id"] + with |manifest|["start_url"]'s origin as the base URL. + </li> + <li>If |id| is failure, return. + </li> + <li>If |id| is not [=same origin=] as |manifest|["start_url"], return. + </li> + <li>Otherwise, set |manifest|["id"] to |id|.</li> + </ol> + <aside class="example"> + <p>Below table shows some example cases of the |identity| processing algorithm.</p> + <table class="data"> + <tr> + <th>|json|["id"]</th> + <th>|manifest|["start_url"]</th> + <th>|manifest|["id"]</th> We might want to add a "rationale" or "discussion" `<th>` to explain why for each case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/988#pullrequestreview-759318208
Received on Tuesday, 21 September 2021 05:38:40 UTC