- From: Nidhi Jaju <notifications@github.com>
- Date: Thu, 28 Oct 2021 00:35:55 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 28 October 2021 07:36:08 UTC
> I looked at this again and it seems that whenever we set the aborted flag we also set the abort reason to a non-undefined value. I think that means we can instead check that abort reason is not undefined. I think that would end up clarifying the overall model a bit and also help with some of the downstream confusion. I'm not sure if this is what you mean, but from what I gathered, you're implying that we should remove the `aborted flag` and use the `abort reason` to check that it is not undefined instead right, as the reason is set whenever the flag is set? If that is the case, I personally think this refactoring should be done as a separate PR, as this PR is about adding `abort reason` to the spec, and removing the aborted flag would make this change more complicated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1027#issuecomment-953579828
Received on Thursday, 28 October 2021 07:36:08 UTC