- From: Nidhi Jaju <notifications@github.com>
- Date: Wed, 27 Oct 2021 06:51:00 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 27 October 2021 13:51:13 UTC
@nidhijaju commented on this pull request. > + 1. If |signal|'s [=AbortSignal/abort reason=] is not undefined, let |error| be |signal|'s + [=AbortSignal/abort reason=]. + 1. Otherwise, let |error| be a new "{{AbortError}}" {{DOMException}}. Ah, fair point. I'll remove the if condition here and just set `error` to the _signal_'s abort reason directly. Do you think it would be a good idea to have an assert here to check that the reason is not undefined just to be sure? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1182#discussion_r737489481
Received on Wednesday, 27 October 2021 13:51:13 UTC