- From: Yutaka Hirano <notifications@github.com>
- Date: Wed, 27 Oct 2021 04:23:51 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 27 October 2021 11:24:03 UTC
@yutakahirano commented on this pull request.
> + 1. If |signal|'s [=AbortSignal/abort reason=] is not undefined, let |error| be |signal|'s
+ [=AbortSignal/abort reason=].
+ 1. Otherwise, let |error| be a new "{{AbortError}}" {{DOMException}}.
Why do we need these logic? `signal.reason` will be an "AbortError" `DOMException` when `controller.abort(undefined)` is called so it should be rare to see `undefined` here. I don't think we should care about the case.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1182#discussion_r737366303
Received on Wednesday, 27 October 2021 11:24:03 UTC