Re: [whatwg/fetch] Add abort reason to abort fetch (PR #1343)

> Unfortunately I think this integration is more complex and it might be best to build on top of @noamr's #1329.
>
> In particular, the problem is this line:
>
>> Terminate the ongoing fetch with the aborted flag set.
>
> That in turn is used to cancel the stream with an "AbortError" deep in the overall fetch algorithm. What we want to do instead is use the reason there.

I think that's not needed because the response body is errored in https://whatpr.org/fetch/1343.html#abort-fetch, and this PR already gives the abort reason to the procedure. The ongoing fetch is terminated but the error objects in "if aborted" steps don't matter as long as #abort-fetch is already called.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1343#issuecomment-952787441

Received on Wednesday, 27 October 2021 10:44:44 UTC