- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 26 Oct 2021 01:58:52 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 26 October 2021 08:59:04 UTC
@annevk commented on this pull request.
Looks good! Excited for this as this will enable timeouts as well. As I mentioned above I think we should have the PRs against the other specifications as well (CI will complain, but that's okay) to get the full picture.
>
+ readonly attribute any reason;
```suggestion
readonly attribute any reason;
```
> + <dt><code><var>signal</var> . <a attribute for=AbortSignal>reason</a></code>
+ <dd>Returns this {{AbortSignal}}'s <a for=AbortSignal>abort reason</a>.
Nit: move this below aborted to keep the same order as the IDL.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1027#pullrequestreview-789063778
Received on Tuesday, 26 October 2021 08:59:04 UTC