- From: Alex Keng <notifications@github.com>
- Date: Mon, 25 Oct 2021 15:42:34 -0700
- To: w3c/editing <editing@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 25 October 2021 22:42:47 UTC
@alexkeng commented on this pull request.
> + computeControlBound() {
+ // implementation omitted for brevity
+ }
+
+ computeCharacterBounds(rangeStart, rangeEnd) {
+ // implementation omitted for brevity
+ }
+ }
+
+ class EditingController {
+ handleSelectionChange() {
+ // Authors are responsible to map the selection from the DOM space to the
+ // plain text space. One approach is to use range.toString() to get the plain text
+ // before the selection start/end, and use the text length as the selection index.
+ let s = document.getSelection()
+ let range = document.createRange()
thanks for the quick review!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/editing/pull/355#discussion_r736017919
Received on Monday, 25 October 2021 22:42:47 UTC