- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 21 Oct 2021 07:45:23 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 21 October 2021 14:45:35 UTC
@domenic commented on this pull request. > <ol> <li><p>Let <var>signal</var> be a new {{AbortSignal}} object. <li><p>Set <var>signal</var>'s [=AbortSignal/aborted flag=]. + <li><p>Set <var>signal</var>'s [=AbortSignal/abort reason=] to <var>reason</var> if it is given; + otherwise to a new "{{AbortError!!exception}}" {{DOMException}}. Interesting. We could instead replace steps 2-3 with "Signal abort on _signal_", but that might be confusing because it does a bunch of extra steps. It's just that those steps aren't observable, and so an implementation could omit them. So I guess either way works, unless @annevk has a preference. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1027#pullrequestreview-785808273
Received on Thursday, 21 October 2021 14:45:35 UTC