- From: Mattias Buelens <notifications@github.com>
- Date: Wed, 20 Oct 2021 16:32:32 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/streams/pull/1180@github.com>
It looks like the spec of "get a promise for waiting for all" changed slightly when it was moved from [the promise guide](https://github.com/w3ctag/promises-guide/blob/135dddc2eeeed7034420ac1050ee66b78775ba77/index.bs#L286-L297) to [Web IDL](https://github.com/whatwg/webidl/blob/68dbd237975f745dfaa3070ebc018ad46d13b0cf/index.bs#L8220-L8236). Notably, the *successSteps* and *failureSteps* arguments were removed, since you can already achieve the same thing by [reacting](https://webidl.spec.whatwg.org/#dfn-perform-steps-once-promise-is-settled) to the returned promise. This updates the reference implementation to align with the definitions from the Web IDL specification. No normative changes. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/1180 -- Commit Summary -- * <a href="https://github.com/whatwg/streams/pull/1180/commits/b714b18068547d3b580b7d15e2fa198e72e00288">Align reference implementation of "wait for all" with latest Web IDL spec</a> * <a href="https://github.com/whatwg/streams/pull/1180/commits/83078d7e105dd4cc1f4e97321deed67ab4ca4fd3">Update spec links for Web IDL in comments</a> -- File Changes -- M reference-implementation/lib/abstract-ops/readable-streams.js (2) M reference-implementation/lib/helpers/webidl.js (52) -- Patch Links -- https://github.com/whatwg/streams/pull/1180.patch https://github.com/whatwg/streams/pull/1180.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1180
Received on Wednesday, 20 October 2021 23:32:44 UTC