- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 19 Oct 2021 08:46:16 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1337/review/783471167@github.com>
@domenic approved this pull request. LGTM with optional suggestion that I'm not too sure about myself. > @@ -4214,12 +4214,12 @@ steps: <dl class=switch> <dt>"<code>about</code>" <dd> - <p>If <var>request</var>'s <a for=request>current URL</a>'s <a>cannot-be-a-base-URL</a> is true - and <a for=url>path</a> contains a single string "<code>blank</code>", then return a new - <a for=/>response</a> whose <a for=response>status message</a> is `<code>OK</code>`, - <a for=response>header list</a> consist of a single <a for=/>header</a> whose - <a for=header>name</a> is `<code>Content-Type</code>` and <a for=header>value</a> is - `<code>text/html;charset=utf-8</code>`, and <a for=response>body</a> is the empty byte sequence. + <p>If <var>request</var>'s <a for=request>current URL</a>'s <a for=url>path</a> is Maybe `the string "blank"` for extra clarity? It's redundant but might help a bit. > @@ -6903,9 +6903,8 @@ constructor steps are: <p>If one of the following is true <ul class=brief> - <li><p><var>parsedReferrer</var>'s <a>cannot-be-a-base-URL</a> is true, <a for=url>scheme</a> - is "<code>about</code>", and <a for=url>path</a> contains a single string - "<code>client</code>" + <li><p><var>parsedReferrer</var>'s <a for=url>scheme</a> is "<code>about</code>" and + <a for=url>path</a> is "<code>client</code>" Similarly here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1337#pullrequestreview-783471167
Received on Tuesday, 19 October 2021 15:46:28 UTC