Re: [whatwg/dom] Add abort reason to AbortSignal (PR #1027)

@nidhijaju commented on this pull request.



> @@ -1762,8 +1763,10 @@ constructor steps are:
 <p>The <dfn attribute for=AbortController><code>signal</code></dfn> getter steps are to return
 <a>this</a>'s <a for=AbortController>signal</a>.
 
-<p>The <dfn method for=AbortController><code>abort()</code></dfn> method steps are to
-<a for=AbortSignal>signal abort</a> on <a>this</a>'s <a for=AbortController>signal</a>.
+<p>The <dfn method for=AbortController><code>abort(reason)</code></dfn> method steps are to
+<a for=AbortSignal>signal abort</a> on <a>this</a>'s <a for=AbortController>signal</a>, with
+the provided <var>reason</var>. If a <var>reason</var> is not passed, create a new "{{AbortError!!exception}}"
+{{DOMException}}.

I was thinking that we could just attach the reason to the signal inside this method itself, so we don't have to add more arguments/logic to the "signal abort" algorithm. Hopefully, that is clearer in my latest changes. Does that sound okay?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1027#discussion_r731700406