Re: [whatwg/fetch] Attach timing info and URL to network errors, and report for fetch API (#1311)

@annevk commented on this pull request.

As for who else to review: ideally the folks I mentioned earlier.

> @@ -206,6 +206,10 @@ lt="authentication entry">authentication entries</a> (for HTTP authentication).
 
  <dt><dfn for="fetch params">timing info</dfn>
  <dd>A <a for=/>fetch timing info</a>.
+
+ <dt><dfn for="fetch params">ready for clients flag</dfn> (initially unset).
+ <dt><dfn for="fetch params">network read complete flag</dfn> (initially unset).
+ <dd>A flag.

I should have said this sooner, but let's remove "flag" from these and make them booleans. Generally we're slowly moving away from flags.

>  </ol>
 
+<p>To <dfn>fetch network finale</dfn> given a <a for=/>fetch params</a> <var>fetchParams</var>
+and a <a for=/>response</a> <var>response</var>, <a>queue a fetch task</a>
+with to run the following steps with <var>fetchParams</var>'s
+<a for="fetch params">task destination</a>:</p>

It seems you forgot to move the steps?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1311#pullrequestreview-780709857

Received on Friday, 15 October 2021 10:53:21 UTC