- From: Anne van Kesteren <notifications@github.com>
- Date: Wed, 13 Oct 2021 05:21:33 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 13 October 2021 12:21:46 UTC
@annevk commented on this pull request. > @@ -4164,24 +4169,28 @@ steps: with <var>fetchParams</var>'s <a for="fetch params">task destination</a>. </ol> -<p>To <dfn export>finalize and report timing</dfn> given a <a for=/>response</a> -<var>response</var>, a <a for=/>global object</a> <var>global</var>, and a <a for=/>string</a> -<var>initiatorType</var> (default "<code>other</code>"), run these steps: +<p>To <dfn export for="fetch controller">abort</dfn> <a for=/>fetch controller</a> +<var>controller</var>, <a for=fetch>terminate</a> the ongoing fetch with the aborted flag set.</p> Terminate also needs to operate on the controller. And the relevant flag can then live there (or on fetch params) and be checked through fetch. That's why I thought it might make sense to scope the initial feature set to that, although I do quite like the direction this is taking as it allows us to remove some baggage from requests and responses. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1329#pullrequestreview-778493519
Received on Wednesday, 13 October 2021 12:21:46 UTC