- From: Domenic Denicola <notifications@github.com>
- Date: Sat, 27 Nov 2021 12:02:04 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 27 November 2021 20:02:16 UTC
@domenic commented on this pull request. I think the existing text is OK as-is, as I think it's basically saying "local scheme is a predicate you can apply to the scheme member of URL records (or something which is on its way to being put into that field), which returns true if the value is...". But I can understand not wanting that kind of implicitness, editorially, so either way seems fine to me. > @@ -2819,14 +2819,8 @@ request <a for=/>header</a> indicates where a <a lt=fetch for=/>fetches</a>. <!-- Ian Hickson told me Adam Barth researched that --> -<p>Its <a for=header>value</a> <a>ABNF</a>: - -<pre><code class=lang-abnf> -Origin = origin-or-null - -origin-or-null = origin / %s"null" ; case-sensitive -origin = <a for=url>scheme</a> "://" <a for=url>host</a> [ ":" <a for=url>port</a> ] -</code></pre> +<p>Its possible <a for=header>values</a> are all the return values of This seems worth a separate PR with its own commit message. I.e. it passes the "I would be interested in seeing a tweet about this" bar, for me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1361#pullrequestreview-817156669
Received on Saturday, 27 November 2021 20:02:16 UTC