Re: [whatwg/streams] Various fixes for readable byte streams (#1123)

@MattiasBuelens commented on this pull request.

There we go. We now use `? TransferArrayBuffer(buffer)` where needed. 😁

I also added a note about `TransferArrayBuffer` and `WebAssembly.Memory`, but I'm not 100% sure if I got the Bikeshed syntax correct.

> +urlPrefix: https://webassembly.github.io/spec/js-api/; spec: WASM-JS-API-1
+ type: interface
+  text: WebAssembly.Memory; url: #memory
+ type: attribute
+  text: buffer; for: WebAssembly.Memory; url: #dom-memory-buffer

No idea if I'm doing this right. It *seems* to work fine? 😬

I'm also not sure why I even need to specify this manually. Am I missing some auto-linking magic that would allow me to just write `{{WebAssembly.Memory}}` and have it automatically find the correct spec (like `{{Response}}` [here](https://github.com/whatwg/streams/blob/0ff6d4508b58acce28386696b2854b2a1570d205/index.bs#L87))?

> +    <p class="note">This will throw an exception if |O| has an \[[ArrayBufferDetachKey]]
+    that is not undefined, such as a {{WebAssembly.Memory}}'s {{WebAssembly.Memory/buffer}}.
+    [[WASM-JS-API-1]]</p>

Maybe double-check this bit too? 😇

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1123#pullrequestreview-662624423

Received on Tuesday, 18 May 2021 22:33:07 UTC