Re: [whatwg/streams] Various fixes for readable byte streams (#1123)

@domenic commented on this pull request.

LGTM with nits

> @@ -3151,8 +3186,8 @@ The following abstract operations support the implementation of the
  id="readable-byte-stream-controller-respond-in-readable-state">ReadableByteStreamControllerRespondInReadableState(|controller|,
  |bytesWritten|, |pullIntoDescriptor|)</dfn> performs the following steps:
 
- 1. If |pullIntoDescriptor|'s [=pull-into descriptor/bytes filled=] + |bytesWritten| >
-    |pullIntoDescriptor|'s [=pull-into descriptor/byte length=], throw a {{RangeError}} exception.
+ 1. Assert: |pullIntoDescriptor|'s [=pull-into descriptor/bytes filled=] + |bytesWritten| <=

```suggestion
 1. Assert: |pullIntoDescriptor|'s [=pull-into descriptor/bytes filled=] + |bytesWritten| ≤
```

> +urlPrefix: https://webassembly.github.io/spec/js-api/; spec: WASM-JS-API-1
+ type: interface
+  text: WebAssembly.Memory; url: #memory
+ type: attribute
+  text: buffer; for: WebAssembly.Memory; url: #dom-memory-buffer

I think the interface name should be `Memory`, so you'd do something like `{{Memory|WebAssembly.Memory}}`. However it appears not to work. I suspect that's because the Bikeshed database does not yet contain the spec: Maybe only when the AppHistory flag is enabled, I dunn

I'd suggest updating this to use `Memory` as the interface name, here and at the usage sites, so that in the future we can delete this link block.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1123#pullrequestreview-663555509