- From: Timothy Gu <notifications@github.com>
- Date: Fri, 30 Jul 2021 10:45:09 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <heycam/webidl/pull/1006/review/719329415@github.com>
@TimothyGu commented on this pull request. Some nits, but LGTM overall. > @@ -6825,11 +6826,13 @@ An <dfn id="dfn-observable-array-type" export>observable array type</dfn> is a p whose values are references to a combination of a mutable list of objects of type |T|, as well as behavior to perform when author code modifies the contents of the list. -The parameterized type must not be a [=dictionary type=], [=sequence type=], or [=record type=]. +The parameterized type must not be a [=dictionary type=], [=sequence type=], [=record type=], or [=observable array type=]. ```suggestion The parameterized type |T| must not be a [=dictionary type=], [=sequence type=], [=record type=], or [=observable array type=]. However, |T| may be nullable. ``` > Similar to [=sequence types=] and [=frozen array types=], observable array types wrap around ECMAScript array types, imposing additional semantics on their usage. +Observable array types are non-nullable, but T may be nullable. I'd suggest removing this sentence, and have the nullability of |T| moved up. It's not that observable array types themselves are non-nullable (every type other than nullable types are non-nullable), but more like they cannot be the inner type of a nullable type. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/1006#pullrequestreview-719329415
Received on Friday, 30 July 2021 17:45:21 UTC