Re: [heycam/webidl] More fixes for observable array type (#1006)

@domenic commented on this pull request.

Great catch.

We should probably also disallow `sequence<ObservableArray<T>>`, `record<DOMString, ObservableArray<T>>`, `FrozenArray<ObservableArray<T>>`, and `Promise<ObservableArray<T>>`.

>  *   another nullable type, or
-*   a [=union type=] that itself [=includes a nullable type=]
+*   an [=union type=] that itself [=includes a nullable type=]

Nit: this should stay "a", see https://www.writersdigest.com/write-better-fiction/a-before-consonants-and-an-before-vowels-is-not-the-rule

>  
 Similar to [=sequence types=] and [=frozen array types=], observable array types wrap around
 ECMAScript array types, imposing additional semantics on their usage.
 
+Observable array types are non-nullable, but T may be nullable.

```suggestion
Observable array types are non-nullable, but |T| may be nullable.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/heycam/webidl/pull/1006#pullrequestreview-719319023

Received on Friday, 30 July 2021 17:30:16 UTC