- From: Jake Archibald <notifications@github.com>
- Date: Sun, 07 Feb 2021 01:17:31 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 7 February 2021 09:17:44 UTC
I don't have strong feeling about my version vs @Jamesernator's. It avoids the callback pattern mine has, which is good if we think my callback pattern is a bit weird. It might not be clear to devs that the inner signal behaves differently to the outer signal. In @Jamesernator's solution it's slightly harder to change the abort tasks mid-way through the task, but I don't know if that's common (it didn't come up in the examples so far). @getify Your example looks pretty weird and I'm not sure what it's trying to achieve. It looks like it creates a strong 1:1 association between signal and task. If that's the case, I don't think we should over-index on this example, since signals tend to span multiple tasks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/issues/946#issuecomment-774640473
Received on Sunday, 7 February 2021 09:17:44 UTC