- From: Joshua Bell <notifications@github.com>
- Date: Mon, 19 Apr 2021 12:53:33 -0700
- To: w3c/FileAPI <FileAPI@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/FileAPI/pull/164/review/639247009@github.com>
@inexorabletash commented on this pull request. Drive-by... > @@ -504,7 +500,7 @@ It must act as follows: <li>Else, let |relativeStart| be <code>min(start, size)</code>. </ol> -3. The optional <dfn argument for="Blob/slice(start, end, contentType)" id="dfn-end">end</dfn> parameter +2. The optional <dfn argument for="Blob/slice(start, end, contentType)" id="dfn-end">end</dfn> parameter Since the spec is already inconsistent about use of 1/1/1/... vs. 1/2/3/..., how about converting this to 1/1/1/... while you're here to save work later? > @@ -1187,7 +1183,7 @@ The {{FileReader}} object must be the event target for all events in this specif When this specification says to <dfn>fire a progress event</dfn> <i>called e</i> (for some {{ProgressEvent}} <code>e</code> -at a given {{FileReader}} <code>reader</code> as the <a>context object</a>), +at a given {{FileReader}} <code>reader</code> as <a>this</a>), Just because "as this" reads poorly, how about just dropping that part of the sentence? I don't think it adds anything. > The <dfn attribute for=FileReader>error</dfn> attribute's getter, -when invoked, must return the [=context object=]'s [=FileReader/error=]. +when invoked, must return [=this=]'s [=FileReader/error=]. <div algorithm="read operation"> A {{FileReader}} |fr| has an associated <dfn id=readOperation>read operation</dfn> algorithm, WDYT about replacing |fr| references in this algorithm with [=this=] ? > The <dfn attribute for=FileReader>error</dfn> attribute's getter, -when invoked, must return the [=context object=]'s [=FileReader/error=]. +when invoked, must return [=this=]'s [=FileReader/error=]. <div algorithm="read operation"> A {{FileReader}} |fr| has an associated <dfn id=readOperation>read operation</dfn> algorithm, And same for "A {{Blob}} |blob| ..." above (line 266, which I can't comment on here) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/FileAPI/pull/164#pullrequestreview-639247009
Received on Monday, 19 April 2021 19:53:45 UTC