- From: Mattias Buelens <notifications@github.com>
- Date: Fri, 16 Apr 2021 17:04:00 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 17 April 2021 00:04:12 UTC
@MattiasBuelens commented on this pull request.
> 1. If |view|.\[[ViewedArrayBuffer]].\[[ArrayBufferByteLength]] is 0, throw a {{TypeError}}
exception.
Hmm, I suppose this check is now made redundant by this check in `ReadableByteStreamControllerRespondWithNewView`:
> 4. If firstDescriptor’s buffer byte length is not view.[[ViewedArrayBuffer]].[[ByteLength]], throw a RangeError exception.
...given that a pull-into's buffer can never be zero length.
I guess we can delete this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1123#pullrequestreview-638143827
Received on Saturday, 17 April 2021 00:04:12 UTC