Re: [w3c/manifest] Adding protocolhandlers (#969)

@marcoscaceres requested changes on this pull request.

Thanks for taking first stab at this @diekus. 

Few things: we've dropped IDL from the spec, so be good to update to match the updated style. Similarly, we don't have "issue a developer warning" anymore.

There also need to be some strong security assurances around those URL replacements. It might be worth looking at how Web Share Target handles that (or perhaps some other specs that do something similar).  

> +        </p>
+      </section>
+      <section>
+        <h3>
+          <dfn>Handling a protocol launch</dfn>
+        </h3>
+        <p>
+          When a <a>ProtocolHandlerItem</a> <var>protocol_handler</var> having
+          <a>WebAppManifest</a> <var>manifest</var> is invoked, run the
+          following steps:
+        </p>
+        <ol>
+          <li>Let <var>url</var> be <var>protocol_handler.url</var>.
+          </li>
+          <li>Replace the first occurrence of the exact literal string "%s" in
+          <var>url</var> with an escaped version of the absolute URL.

The "an escaped version" needs some definition (or link to) of how to do the escaping.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/969#pullrequestreview-635199132