- From: Mason Freed <notifications@github.com>
- Date: Tue, 13 Apr 2021 13:01:52 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/966/review/634977035@github.com>
@mfreed7 commented on this pull request. > <li> - <p>For each <a>slottable</a> <a for=tree>child</a> of <var>host</var>, <var>slottable</var>, in + <p>Otherwise, for each <a>slottable</a> <a for=tree>child</a> of <var>host</var>, <var>slottable</var>, in Yeah sorry, good point. That's not a great example. So you'd prefer this? ```javascript const shadow = host.attachShadow({mode: 'open'}); // "named" slot assignment shadow.appendChild(slot); slot.assign([a,b,c]); // Has no effect ``` I suppose I could live with this. It just feels weird that the entire point of all of this conversation was to make the node-to-slot assignments "sticky" across all kinds of tree mutations. But then this would be the one exception - you can move a node or a slot anywhere in any tree and the references will be maintained, **except** if any stop is ever within a "named"-assignment shadow root. Given the fact that the node references are unobservable, there will definitely be cases that are a bit hard to understand for developers. E.g. assigning a node to a slot, and then making the node a grandchild (instead of direct child) of the host. We'll need to develop developer tooling to make this situation better. But I don't think adding even more magic is the answer. Again, I'm ok either way, just trying to get this right. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/966#discussion_r612738864
Received on Tuesday, 13 April 2021 20:02:10 UTC