Re: [whatwg/url] Base URL Windows drive sometimes favoured over input string drive (#574)

Yeah thats nice! (@karwa)

I found seven of your tests that are related to this very issue, and whose behaviour would change. Can I include them in my 'proposal' PR to the tests? I can also wait till your tests are upstreamed and adapt them after. 

Quote: 
> As you can see, in most cases we take the drive "D" from the input string, even when it isn't literally the first component, except for this one case.

In summary, and to gather some feedback, my idea is to prevent the issue by not converting segments to a drive unless it **is** literally the first component (of the host/path in the input string). I think this is what people would expect, and it seems to be not far off from browser behaviour. If possible, @achristensen07, (and others) do you have an opinion about that approach? Since it will incur a few changes to Safari. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/issues/574#issuecomment-818652335

Received on Tuesday, 13 April 2021 11:10:09 UTC