- From: Mason Freed <notifications@github.com>
- Date: Fri, 09 Apr 2021 12:47:38 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 9 April 2021 19:47:50 UTC
@mfreed7 commented on this pull request. > @@ -2192,6 +2192,10 @@ steps:</p> <li><p>If the <i>open flag</i> is set and <var>shadow</var>'s <a for=ShadowRoot>mode</a> is <em>not</em> "<code>open</code>", then return null.</p></li> + <li><p>If <var>shadow</var>'s <a for=ShadowRoot>slot assignment</a> is "<code>manual</code>", + then return the <a>slot</a> in <var>shadow</var>'s <a for=tree>descendants</a> whose <a>manually assigned nodes</a> Ok great. And that's a great point about a slot with manually assigned nodes that is living in a shadow host in "named" mode. I agree with the behavior you proposed, and I'll try to get it written up. There are a number of potentially confusing things that the developer can do here, and I'm wondering which of them (if any) should get helpful console warnings. I feel like there will be a tough balance to strike between log spam and a lack of understanding of what's going on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/966#discussion_r610869331
Received on Friday, 9 April 2021 19:47:50 UTC