Re: [whatwg/dom] Add "precustomized" custom element state (#894)

@rniwa commented on this pull request.



> @@ -5875,19 +5875,19 @@ dictionary ShadowRootInit {
 initialized.
 
 <p>An <a for=/>element</a>'s <a for=Element>custom element state</a> is one of
-"<code>undefined</code>", "<code>failed</code>", "<code>uncustomized</code>", or
-"<code>custom</code>". An <a for=/>element</a> whose <a for=Element>custom element state</a> is
-"<code>uncustomized</code>" or "<code>custom</code>" is said to be
-<dfn export id=concept-element-defined for=Element>defined</dfn>. An <a for=/>element</a> whose
-<a for=Element>custom element state</a> is "<code>custom</code>" is said to be
-<dfn export id=concept-element-custom for=Element>custom</dfn>.
+"<code>undefined</code>", "<code>failed</code>", "<code>uncustomized</code>",
+"<code>precustomized</code>", or "<code>custom</code>". An <a for=/>element</a> whose
+<a for=Element>custom element state</a> is "<code>uncustomized</code>" or "<code>custom</code>"
+is said to be <dfn export id=concept-element-defined for=Element>defined</dfn>. An
+<a for=/>element</a> whose <a for=Element>custom element state</a> is "<code>precustomized</code>"
+or "<code>custom</code>" is said to be <dfn export id=concept-element-custom for=Element>custom</dfn>.

I don't think it's right to consider "precustomized" state as **custom** either.
This would mean that in the upgrade case, you can insert the node into a document tree before `super()` is the called, and the spec text will try to look for its **custom element definition** and fail, which would be self contradictory.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/894#pullrequestreview-496114014

Received on Friday, 25 September 2020 05:10:55 UTC