- From: Mason Freed <notifications@github.com>
- Date: Thu, 24 Sep 2020 23:19:45 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/894/review/496137476@github.com>
@mfreed7 commented on this pull request. > @@ -5875,19 +5875,19 @@ dictionary ShadowRootInit { initialized. <p>An <a for=/>element</a>'s <a for=Element>custom element state</a> is one of -"<code>undefined</code>", "<code>failed</code>", "<code>uncustomized</code>", or -"<code>custom</code>". An <a for=/>element</a> whose <a for=Element>custom element state</a> is -"<code>uncustomized</code>" or "<code>custom</code>" is said to be -<dfn export id=concept-element-defined for=Element>defined</dfn>. An <a for=/>element</a> whose -<a for=Element>custom element state</a> is "<code>custom</code>" is said to be -<dfn export id=concept-element-custom for=Element>custom</dfn>. +"<code>undefined</code>", "<code>failed</code>", "<code>uncustomized</code>", +"<code>precustomized</code>", or "<code>custom</code>". An <a for=/>element</a> whose +<a for=Element>custom element state</a> is "<code>uncustomized</code>" or "<code>custom</code>" +is said to be <dfn export id=concept-element-defined for=Element>defined</dfn>. An +<a for=/>element</a> whose <a for=Element>custom element state</a> is "<code>precustomized</code>" +or "<code>custom</code>" is said to be <dfn export id=concept-element-custom for=Element>custom</dfn>. Hmm, I added this in response to a comment from @annevk on [DOM-893](https://github.com/whatwg/dom/pull/893). How would you recommend writing [this check](https://github.com/whatwg/dom/pull/893/files#diff-a467e681501e456ce8c1ef31425e1b41R6744), which is meant to check for "precustomized" or "custom". As @annevk pointed out, the definition of "custom element" is "custom element state is custom". I would assume you would just prefer that check (in 893) to say this? > If this's custom element state is "precustomized" or "custom", set shadow's **available to element internals** property to true. Otherwise, set it to false. ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/894#discussion_r494770511
Received on Friday, 25 September 2020 06:19:58 UTC