- From: Domenic Denicola <notifications@github.com>
- Date: Fri, 18 Sep 2020 08:27:37 -0700
- To: heycam/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 18 September 2020 15:27:49 UTC
@domenic approved this pull request. LGTM too. As noted in IRC, I think originally the intention was that "Upon fulfillment" and "Upon rejection" not return anything, and that people use "reacting" if they want to return. But looking back on it, that was kind of dumb. It's just less powerful for no reason, and causes spec authors pain when they don't realize the intention. So the change here to make them return is good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/heycam/webidl/pull/922#pullrequestreview-491567945
Received on Friday, 18 September 2020 15:27:49 UTC