- From: Andreu Botella <notifications@github.com>
- Date: Mon, 26 Oct 2020 09:26:05 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 26 October 2020 16:26:18 UTC
@andreubotella approved this pull request. The note to "encode or fail" has "keep an encoder alive" and "supplying the same encoder". The domintros also have language like "running encoding's decoder", but since "running" isn't linked to the algorithm (see #245) and encoder/decoder instances can be seen as equivalent to a generator, I guess that's fine. Other than that, LGTM. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/pull/241#pullrequestreview-516954844
Received on Monday, 26 October 2020 16:26:18 UTC