- From: Andreu Botella <notifications@github.com>
- Date: Fri, 23 Oct 2020 12:16:41 -0700
- To: whatwg/encoding <encoding@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 23 October 2020 19:16:53 UTC
@andreubotella commented on this pull request. You're missing "an instance of" in UTF-8 decode without BOM or fail. Also in TextDecoderCommon's "decoder" and TextEncoderStream's "encoder" associated fields. I'd also add some clarification on the fact that encoders and decoders are abstract and their state goes on instances: > Each encoding has an associated decoder and most of them have an associated encoder. Encoders and decoders are stateless, but they can be used to create instances which might have state, and which have a handler algorithm. > @@ -1597,8 +1586,8 @@ method steps are: <ol> <li><p>Let <var>item</var> be the result of <a>reading</a> from <var>source</var>. - <li><p>Let <var>result</var> be the result of running the <a>UTF-8 encoder</a>'s <a>handler</a> - on <var>unused</var> and <var>item</var>. + <li><p>Let <var>result</var> be the result of running <var>encoder</var>'s <a>handler</a> on ```suggestion <li><p>Let <var>result</var> be the result of <a>running</a> <var>encoder</var>'s <a>handler</a> on ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/encoding/pull/241#pullrequestreview-515935136
Received on Friday, 23 October 2020 19:16:53 UTC