Re: [whatwg/url] Refactor query state to operate on a buffer (#558)

@domenic approved this pull request.

It looks like I can't really test this with jsdom/whatwg-url since we're still UTF-8 only. So my review of the second commit is just editorial.

Maybe I should sink some time into fixing that, but doing it properly would probably require a from-scratch implementation of the Encoding standard which exposes all of the spec-level primitives. Probably not something I can tackle any time soon...

>    </ol>
 
  <li><p>Return <var>output</var>.
 </ol>
 
 <p>To <dfn for="code point" id=utf-8-percent-encode>UTF-8 percent-encode</dfn> a
 <a for=/>code point</a> <var>codePoint</var> using a <var>percentEncodeSet</var>, return the result
-of running <a for="code point">percent-encode after encoding</a> with <a for=/>UTF-8</a>,
-<var>codePoint</var>, and <var>percentEncodeSet</var>.
+of running <a for=string>percent-encode after encoding</a> with <a for=/>UTF-8</a>,
+<var>codePoint</var> as <a for=/>string</a>, and <var>percentEncodeSet</var>.

```suggestion
<var>codePoint</var> as a <a for=/>string</a>, and <var>percentEncodeSet</var>.
```

>  
 <p>To <dfn export for=string>UTF-8 percent-encode</dfn> a <a for=/>string</a> <var>input</var> using
 a <var>percentEncodeSet</var>, return the result of running
 <a for=string>percent-encode after encoding</a> with <a for=/>UTF-8</a>, <var>input</var>,
-<var>percentEncodeSet</var>, and false.
+<var>percentEncodeSet</var>.

```suggestion
and <var>percentEncodeSet</var>.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/558#pullrequestreview-515875203