Re: [w3c/ServiceWorker] Add `ServiceWorkerRegistration.id` and supporting algorithm changes. (Fixes #1512) (#1526)

@annevk commented on this pull request.



> @@ -683,6 +702,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
     </pre>
     <pre class="idl" id="registration-option-list-dictionary">
       dictionary RegistrationOptions {
+        DOMString id;

Please write a test with isolated surrogates to ensure implementations do not use UTF-8 to store these strings. (If you decide to change this to USVString to allow implementations to do that it's probably still worth writing a test.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1526#pullrequestreview-506499125