Re: [whatwg/url] Fix file URL reparse issue (#550)

@annevk that's true. Step 3 does a bit of resolving inside the serializer, and the check for a null host in 2.1.4 is superfluous if you maintain the invariant that (resolved) file URLs have a non-null host. I don't see any other places either, but I'm not _that_ familiar with this parser so I may have missed something. It seems removing step 3. in the serializer will also solve the idempotency issue, just then you allow null hosts in file URLs. 

You could choose to merge this request and make larger changes later, for example together with changes such as for #548. I would try to move any resolving logic out of the serializer, but also prepare for moving it out of the parser. That's another, much larger topic though. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/550#issuecomment-704832437

Received on Wednesday, 7 October 2020 10:04:34 UTC