Re: [w3c/manifest] chore: refactor and export scope terms (#882)

@mgiuca commented on this pull request.



> @@ -522,13 +521,13 @@ <h2>
       </div>
       <p>
         If the <a>application context</a>'s <a>active document</a>'s
-        [=Document/URL=] is not <a data-lt="within-scope-manifest">within
-        scope</a> of the <a>application context</a>'s manifest, the user agent
-        SHOULD show a prominent UI element indicating the [=Document/URL=] or
-        at least its <a>origin</a>, including whether it is served over a
-        secure connection. This UI SHOULD differ from any UI used when the
-        [=Document/URL=] is <a>within scope</a>, in order to make it obvious
-        that the user is navigating off scope.
+        [=Document/URL=] is not [=within manifest scope=] of the <a>application

How strongly do you feel about renaming this? I deliberately named this "within scope" (the same name as the other definition), designed to be a sort of C++ overloading of the name.

So that anywhere else, I can write "if _x_ is within scope of _app manifest_", without having to clarify that I am invoking this definition, or the other one. (And link to the correct one.) I would prefer to be able to keep doing that, rather than having to update all of the other usages of this to "within manifest scope of _app manifest_".

> @@ -522,13 +521,13 @@ <h2>
       </div>
       <p>
         If the <a>application context</a>'s <a>active document</a>'s
-        [=Document/URL=] is not <a data-lt="within-scope-manifest">within
-        scope</a> of the <a>application context</a>'s manifest, the user agent
-        SHOULD show a prominent UI element indicating the [=Document/URL=] or
-        at least its <a>origin</a>, including whether it is served over a
-        secure connection. This UI SHOULD differ from any UI used when the
-        [=Document/URL=] is <a>within scope</a>, in order to make it obvious
-        that the user is navigating off scope.
+        [=Document/URL=] is not [=within manifest scope=] of the <a>application

I see you updated some (maybe not all?) of the other references to distinguish "within the navigation scope of" and "within manifest scope of". Note that there are other references to this concept from other WICG documents (even if this is not properly exported), like Web Share and File Handling.

I would prefer that we don't have to add that verbosity to what I imagine are a huge amount of usages.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/882#pullrequestreview-420654616

Received on Friday, 29 May 2020 05:08:06 UTC