- From: yuzhehan <notifications@github.com>
- Date: Thu, 14 May 2020 14:15:42 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 14 May 2020 21:15:55 UTC
@annevk, Thanks for your review. I updated the corresponding HTML spec to include the concept of manuallyAssignedNodes and used that concept within [find a slot]. In addition, I removed a number of steps under [find a slot][step 5] where slotAssignment == 'manual'. I found those steps complicates things and unnecessary. Hopefully, the new revision is more clear. I didn't want my local branch to be too far out of date, so I fetched from whatwg:master and rebased my changes on top. It changed history so now your previous reviews aren't matched. Maybe I should have done a merge instead? Sorry for any inconvenience. Thanks again for your review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/860#issuecomment-628890584
Received on Thursday, 14 May 2020 21:15:55 UTC