Re: [whatwg/url] Editorial: use an encode set in the query state (#508)

@domenic requested changes on this pull request.

Seems worth doing if you define two sets.

> @@ -173,8 +173,15 @@ bytes that are not <a>ASCII bytes</a> might be insecure and is not recommended.
 <p>The <dfn oldids=simple-encode-set>C0 control percent-encode set</dfn> are the <a>C0 controls</a>
 and all <a>code points</a> greater than U+007E (~).
 
+<p>The <dfn>query percent-encode set</dfn> is the <a>C0 control percent-encode set</a> and
+U+0020 SPACE, U+0022 ("), U+0023 (#), U+003C (&lt;), and U+003E (>).
+<!-- Do not change this without double checking QUERY-UNITS -->
+
+<p class="note">For <a lt="is special">special</a> <a for=/>URLs</a> the <a>query state</a> adds
+U+0027 (') to this set.

"adds to this set" is a bit confusing, as it might imply the set is mutated. Maybe "the actual set used also contains"? Or maybe just define two sets?

> @@ -173,8 +173,15 @@ bytes that are not <a>ASCII bytes</a> might be insecure and is not recommended.
 <p>The <dfn oldids=simple-encode-set>C0 control percent-encode set</dfn> are the <a>C0 controls</a>
 and all <a>code points</a> greater than U+007E (~).
 
+<p>The <dfn>query percent-encode set</dfn> is the <a>C0 control percent-encode set</a> and
+U+0020 SPACE, U+0022 ("), U+0023 (#), U+003C (&lt;), and U+003E (>).
+<!-- Do not change this without double checking QUERY-UNITS -->
+
+<p class="note">For <a lt="is special">special</a> <a for=/>URLs</a> the <a>query state</a> adds
+U+0027 (') to this set.

Yeah, reading the cloning and stuff required, I think just define two sets.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/508#pullrequestreview-409401775