- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 11 May 2020 10:58:03 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/url/pull/507/review/409396559@github.com>
@domenic commented on this pull request.
> @@ -2914,73 +2906,71 @@ url.pathname // "/%F0%9F%8F%B3%EF%B8%8F%E2%80%8D%F0%9F%8C%88"</code></pre>
<hr id=urlutils-members>
-<p>The <dfn attribute for=URL><code>href</code></dfn> attribute's getter and the
-<dfn method for=URL><code>toJSON()</code></dfn> method, when invoked, must return the
-<a lt="URL serializer">serialization</a> of <a>context object</a>'s <a for=URL>url</a>.
+<p>The <dfn attribute for=URL><code>href</code></dfn> attribute's getter steps and the
Remove "attribute" here and elsewhere per latest discussions.
> </ol>
-<p>The <dfn constructor for=URLSearchParams><code>URLSearchParams(<var>init</var>)</code></dfn>
-constructor, when invoked, must run these steps:</p>
+<p>The
+<dfn constructor for=URLSearchParams lt="URLSearchParams(init)"><code>new URLSearchParams(<var>init</var>)</code></dfn>
Filed https://github.com/tabatkins/bikeshed/issues/1667
>
<ol>
- <li><p>If there are any name-value pairs whose name is <var>name</var>, in
+ <li><p>If there are any name-value pairs whose name is <var>name</var>, in <a>this</a>'s
<a for=URLSearchParams>list</a>, set the value of the first such name-value pair to
If this's list contains any name-value pairs whose name is name
> </ol>
<hr>
-<p>The <a>value pairs to iterate over</a> are the
-<a for=URLSearchParams>list</a> name-value pairs with the key being
-the name and the value being the value.
+<p>The <a>value pairs to iterate over</a> are <a>this</a>'s <a for=URLSearchParams>list</a>
list's?
>
-<p>The <dfn for=URLSearchParams>stringification behavior</dfn> must return the
-<a lt='urlencoded serializer'>serialization</a> of the {{URLSearchParams}} object's
-<a for=URLSearchParams>list</a>.
+<p>The <dfn for=URLSearchParams>stringification behavior</dfn> steps are to return the
+<a lt='urlencoded serializer'>serialization</a> of <a>this</a>'s <a for=URLSearchParams>list</a>.
single quotes here is unusual
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/507#pullrequestreview-409396559
Received on Monday, 11 May 2020 17:58:15 UTC