Re: [whatwg/fetch] Add style rules (#1036)

@annevk commented on this pull request.

Thank you for writing this up, this is great! I have a couple nits and suggestions.

> @@ -80,6 +80,40 @@ is.
 End tags must be omitted when possible and attribute values must not be quoted (if necessary, use
 double quotes).
 
+Place one new line between paragraphs (including list elements). Place two or more new lines before

newline* throughout.

> @@ -80,6 +80,40 @@ is.
 End tags must be omitted when possible and attribute values must not be quoted (if necessary, use
 double quotes).
 
+Place one new line between paragraphs (including list elements). Place two or more new lines before
+headings (e.g., `<h3>`). This doesn't apply when a nested heading follows the parent heading.

Headings depend on their heading level, but I've probably not always been consistent. `<h2>` gets three newlines, the remainder two. As the size of the document increases it might make sense to adjust this to give even more spacing for the larger sections.

> +
+ <li><p>Place a new line above.
+</ul>
+
+<p>Place a new line above.
+
+
+<h3>Place two or more new lines above.</h3>
+
+<h4>Placing one new line is OK here.</h4>
+
+
+<h4>Place two or more new lines above.</h4>
+```
+
+Use camelCase for variable names. On the other hand, it is OK to use spaced names for defined

I would strike "it is OK to" as it's in fact the style to use spaced names there and it would probably not be okay to use camel case there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1036#pullrequestreview-429659559