Re: [whatwg/dom] Add declarative Shadow DOM features (#858)

Thanks for the review! I think i I addressed all of your comments, but let me know what else needs attention.

> FWIW, I think that apart from formatting (and it needs rebasing), this largely looks fine. Cloning shadow trees looks rather odd to me though. The explainer also doesn't go into this from a quick scan.

This is a good point, which wasn't previously in the explainer. I came across this behavior as I was implementing. Based on this comment, I've added a section to the explainer that details why this change was necessary - you can see that [here](https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#ordinary-templates-containing-declarative-shadow-dom). The TL/DR is that without this change (or something similar), you can't use declarative Shadow DOM inside an "ordinary" template.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/858#issuecomment-642944808