Re: [whatwg/streams] Editorial: add cross-links to internal slots (#1050)

> Feel free to throw [154bfb4](https://github.com/whatwg/streams/commit/154bfb4edada8f7004c621c89c6176a6c96ff075) into #1051 if you want to morph that into a general "editorial fixups" PR.

Looks like 154bfb4edada8f7004c621c89c6176a6c96ff075 has already been superseded by 63b4407f424d6ad042852b3d225b7c0ffa116b2d. 😄 I'll get rid of that commit next time I rebase this PR.

> The alternative I can think of is just assuming internal slot names are unique, and then removing the `dfn-for=""`. However, we have a few collisions these days (since we are no longer using internal slots for brand checking), and I'd like to introduce more going forward, e.g. `[[readableStreamController]]` -> `[[controller]]`. So that would only work in some cases, and we'd need `for=""` for others. I think this is reasonable.

Yeah, there's no way to make all internal slots unique, I'm afraid. Both `ReadableStreamDefaultReader` and `ReadableStreamBYOBReader` have `[[closedPromise]]` and `[[ownerReadableStream]]` slots, and although they serve the same purpose, they're *technically* different slots. Oh, and of course there's also `WritableStreamDefaultWriter` with its own `[[closedPromise]]` slot.

I'm a big fan of renaming things like `[[readableStreamController]]` to just `[[controller]]`. And I agree, we should probably do those renames *first*. 👍

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1050#issuecomment-654465378