Re: [whatwg/streams] Editorial: various fixes (#1051)

@domenic approved this pull request.

> Uhm, I thought the whole point of #1029 was to change the asserts into early-exits, so that if other specs want to use the abstract op, they don't have to do the checks themselves? Now you want to change them back to asserts? I'm not sure I'm following... 😕

Yeah, OK, fair... I guess I'm still kind of uneasy with the resolution of https://github.com/whatwg/streams/pull/1029, based on the fact that it's untestable and the comment in https://github.com/whatwg/streams/pull/1029#issuecomment-597393575. I think our best path forward is to just finish up this PR's uncontroversial aspects, and then maaaaybe come back to the early-exit vs. throw vs. assert discussion separately. Maybe after I eventually create a better interface for other specs to use streams abstract ops (https://github.com/whatwg/streams/issues/372).

In which case, this LGTM. I'll let @ricea have another look though just in case, before merging.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1051#pullrequestreview-443398682