Re: [whatwg/encoding] Use new Streams algorithm and mixins (#224)

@annevk approved this pull request.

I really like leaning into IDL more heavily for doing the promise wrapping. I should do that more often.

>   <li><p>Let <var>transformAlgorithm</var> be an algorithm which takes a <var>chunk</var> argument
  and runs the <a>decode and enqueue a chunk</a> algorithm with <a>this</a> and <var>chunk</var>.
 
  <li><p>Let <var>flushAlgorithm</var> be an algorithm which takes no arguments and runs the
  <a>flush and enqueue</a> algorithm with <a>this</a>.
 
- <li><p>Let <var>transform</var> be the result of calling
- <a abstract-op>CreateTransformStream</a>(<var>startAlgorithm</var>, <var>transformAlgorithm</var>,
- <var>flushAlgorithm</var>).
-
- <li><p>Set <a>this</a>'s <a for=GenericTransformStream>transform</a> to <var>transform</var>.
+ <li><p>Set <a>this</a>'s <a for=GenericTransformStream>transform</a> to the result of
+ <a for=TransformStream>creating</a> a {{TransformStream}} with

```suggestion
 <a for=TransformStream>creating</a> a {{TransformStream}} object with
```

>      </ol>
 
    <li><p>Let <var>result</var> be the result of <a>processing</a> <var>token</var> for
    <var>decoder</var>'s <a for=TextDecoderCommon>decoder</a>, <var>decoder</var>'s
    <a for=TextDecoderCommon>stream</a>, <var>output</var>, and <var>decoder</var>'s
    <a for=TextDecoderCommon>error mode</a>.
 
-   <li><p>If <var>result</var> is <a>error</a>, then return a new promise rejected with a
-   {{TypeError}} exception.
+   <li><p>If <var>result</var> is <a>error</a>, then throw a {{TypeError}} exception.

Should we drop the trailing " exception" here as we do in other standards?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/encoding/pull/224#pullrequestreview-477487989