Re: [whatwg/fetch] Use new Streams algorithms (#1085)

@annevk commented on this pull request.

Lovely! Many years in the making and we're finally almost there.

@yutakahirano would be great to get your take on this as well.

> @@ -1024,8 +1024,8 @@ user-agent-defined <a for=header>value</a> for the
 <a for=/>body</a> <var>body</var>, run these steps:
 
 <ol>
- <li><p>Let «<var>out1</var>, <var>out2</var>» be the result of
- <a lt=tee for=ReadableStream>teeing</a> <var>body</var>'s <a for=body>stream</a>.
+ <li><p>Let «<var>out1</var>, <var>out2</var>» be the result of <a for=ReadableStream>teeing</a>

Nit: should there be a space after « and before »?

> @@ -4990,20 +4801,20 @@ Range Requests</cite>. [[HTTP-RANGE]] However, this is not widely supported by b
          <li><p>If <var>bytes</var> is failure, then <a lt=terminated for=fetch>terminate</a> the
          ongoing fetch.
 
-         <li><p><a for=ReadableStream>Enqueue bytes</a> given <var>bytes</var> and
-         <var>stream</var>.
+         <li><p><a for=ReadableStream>Enqueue</a> a {{Uint8Array}} wrapping an {{ArrayBuffer}}

Uint8Array object*
ArrayBuffer object*

And the same below. It's a little unfortunate this duplicates the creation of these objects again, but that's probably fine for now. At some point we probably want an operation that you give a byte sequence and a realm and it returns this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1085#pullrequestreview-477455123

Received on Friday, 28 August 2020 08:08:23 UTC