Re: [w3ctag/design-reviews] Constant bitrate audio encoding with MediaRecorder (#540)

> Hi @simoncent,
> 
> Thanks for bringing this to us. Overall, this looks like a very reasonable, incremental API improvement to me. I have one concern, with the values of your `BitrateMode` enum:
> 
> ```webidl
> enum BitrateMode {
>   "cbr",
>   "vbr"
> };
> ```
> 
> Maybe don't abbreviate these? I think `"constant"` and `"variable"` could be clearer to folks, and are easier to hear correctly when someone speaks them. See also our [advice on naming](https://w3ctag.github.io/design-principles/#naming-is-hard), in particular [Use common words](https://w3ctag.github.io/design-principles/#naming-common-words).

That sounds reasonable to me, I'll open a PR to update the editors draft with the change.


> Also, we generally recommend that folks make their explainers available in Markdown or HTML; Google Docs is not globally accessible, but participants in web standards are.

Thanks for the tip, are you highlighting this for future reference or are you requesting that I replace the explainer for this issue?

Thanks for your time!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/540#issuecomment-679890864

Received on Tuesday, 25 August 2020 08:43:40 UTC