Re: [w3ctag/design-reviews] Constant bitrate audio encoding with MediaRecorder (#540)

Hi @simoncent,

Thanks for bringing this to us. Overall, this looks like a very reasonable, incremental API improvement to me. I have one concern, with the values of your `BitrateMode` enum:

```webidl
enum BitrateMode {
  "cbr",
  "vbr"
};
```

Maybe don't abbreviate these? I think `"constant"` and `"variable"` could be clearer to folks, and are easier to hear correctly when someone speaks them. See also our [advice on naming](https://w3ctag.github.io/design-principles/#naming-is-hard), in particular [Use common words](https://w3ctag.github.io/design-principles/#naming-common-words).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/540#issuecomment-679424638

Received on Monday, 24 August 2020 23:58:43 UTC